tls: share the builtin stat name set across all TLS contexts - #46469
Open
briansonnenberg wants to merge 1 commit into
Open
tls: share the builtin stat name set across all TLS contexts#46469briansonnenberg wants to merge 1 commit into
briansonnenberg wants to merge 1 commit into
Conversation
kyessenov
reviewed
Jul 30, 2026
kyessenov
reviewed
Jul 30, 2026
kyessenov
left a comment
kyessenov
left a comment
Contributor
There was a problem hiding this comment.
LGTM to me. Please fix the CI and dial-down the AI description tone :) I'll assign to @ggreenway since this is core code, and we need a second set of eyes.
Contributor
Author
|
/retest |
briansonnenberg
force-pushed
the
brian_opts
branch
2 times, most recently
from
August 3, 2026 20:44
16404a7 to
85f9698
Compare
Each ContextImpl previously allocated a separate StatNameSet for BoringSSL ciphers, curves, signature algorithms, and versions. Since these built-in names are constant across contexts, creating them per context duplicated symbol table encodes and memory overhead during SDS rotations. Move built-in TLS stat names into a single object managed via the server singleton manager. Each ContextImpl holds a shared_ptr to the singleton instance. TAG=agy Signed-off-by: Brian Sonnenberg <bsonnenberg@google.com>
briansonnenberg
force-pushed
the
brian_opts
branch
from
August 3, 2026 21:33
85f9698 to
ba2553d
Compare
Contributor
Author
|
@ggreenway Could you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each ContextImpl previously allocated a separate StatNameSet for BoringSSL ciphers, curves, signature algorithms, and versions. Since these built-in names are constant across contexts, creating them per context duplicated symbol table encodes and memory overhead during SDS rotations.
Move built-in TLS stat names into a single object managed via the server singleton manager. Each ContextImpl holds a shared_ptr to the singleton instance.
TAG=agy
Additional Description: N/A
Risk Level: low
Testing: Existing test suites validate these stats.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A