fix: download-all returns error on partial failures

[Hinne1]

Summary

• --download-all was returning exit code 0 even when individual file downloads failed
• Callers (scripts, CI) had no way to detect partial failures
• Now returns a non-zero exit code with error message when any downloads fail

Context

Discovered while building a Confluence space backup script — the script's retry logic couldn't detect failed attachment downloads because the CLI always exited 0.

Test plan

• atl confluence page attachment <id> --download-all with a page that has attachments returns 0 on success
• Same command returns non-zero when downloads fail (e.g. scope issue, network error)

[gemini-code-assist]

Code Review

This pull request introduces error reporting for partial failures in the attachment download process by checking the error count before returning. However, the current implementation bypasses this check when JSON output is enabled, which needs to be addressed to ensure consistent exit codes.

[Hinne1]

@gemini-code-assist — good catch on the JSON early return. Fixed in 94cdf73: the --json path now writes output first, then checks len(errors) and returns non-zero on failures. Both output paths are now consistent.

[gemini-code-assist]

Thanks for the update, Hinne1. The logic in internal/cmd/confluence/page/attachment.go now correctly ensures that partial failures are reported via a non-zero exit code regardless of the output format, which is a significant improvement for CI/CD pipelines and automation scripts.

[github-actions]

Merging this branch will not change overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/enthus-appdev/atl-cli/internal/cmd/confluence/page	0.00% (ø)

---

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/enthus-appdev/atl-cli/internal/cmd/confluence/page/attachment.go	0.00% (ø)	163 (+6)	0	163 (+6)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.