Update keyboard bindings for DEVICE_ID_KEYBOARD#2572
Merged
Conversation
Prior to Godot 4.7, keyboard (and mouse) events were reported with `device` set to `0`. But this overlaps with `0` meaning "the 0th gamepad". Godot 4.7 introduced `DEVICE_ID_KEYBOARD = 16` (and `DEVICE_ID_MOUSE = 32`). The gap is future-proofing for supporting multiple keyboards. Our `InputEventKey` bindings in `project.godot` are stored with device 0. If you make any changes to our `project.godot` with 4.7 and save it, these are updated to device 16. Commit this.
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/update-keyboard-bindings-for-device-id-keyboard/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update keyboard bindings for DEVICE_ID_KEYBOARD
Prior to Godot 4.7, keyboard (and mouse) events were reported with
deviceset to0. But this overlaps with0meaning "the 0thgamepad".
Godot 4.7 introduced
DEVICE_ID_KEYBOARD = 16(andDEVICE_ID_MOUSE = 32). The gap is future-proofing for supporting multiple keyboards.Our
InputEventKeybindings inproject.godotare stored with device0. If you make any changes to our
project.godotwith 4.7 and save it,these are updated to device 16. Commit this.