renya: Set music as looping#2506
Merged
Merged
Conversation
All these tracks are designed to loop, but the loop flag was not set in their import settings, so the music would simply stop at the end of the track rather than looping. Set the loop flag. While we're here, set the beats per bar and bpm (both of which seem to be regular throughout each piece) in case someone wants to do something fancy with them in future.
Member
Author
|
I noticed this while reviewing #2428 which reuses one of these tracks. |
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/renya-set-music-as-looping/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Jul 6, 2026
manuq
left a comment
manuq
left a comment
Collaborator
There was a problem hiding this comment.
Good to know about the bpm and bar_beats!
Member
Author
That's how the switch from Void Still to Void Creep is synced to the first beat of a bar of Still :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All these tracks are designed to loop, but the loop flag was not set in
their import settings, so the music would simply stop at the end of the
track rather than looping.
Set the loop flag. While we're here, set the beats per bar and bpm (both
of which seem to be regular throughout each piece) in case someone wants
to do something fancy with them in future.