Do not error on messages from terminated workers - #27471
Open
tlively wants to merge 2 commits into
Open
Conversation
Messages can generally arrive after a worker has terminated if the message being sent races with the thread shutting down. This does not cause any problems, and the logging made it possible for expected test output to be interrupted.
Member
Author
|
Noticed by Gemini while it was supposed to be working on something else. Thanks, I guess. |
Collaborator
|
See also PR #27012, where this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messages can generally arrive after a worker has terminated if the message being sent races with the thread shutting down. This does not cause any problems, and the logging made it possible for expected test output to be interrupted.