Re-enable use of symlinks for shell script launchers on UNIX - #27466
Open
sbc100 wants to merge 1 commit into
Open
Re-enable use of symlinks for shell script launchers on UNIX#27466sbc100 wants to merge 1 commit into
sbc100 wants to merge 1 commit into
Conversation
Now that Windows launchers use `pylauncher.exe`, shell script launchers are no longer needed on Windows for MINGW compatibility. We can revert the behavior from emscripten-core#10921 (commit 1c6e796) and use symbolic links on UNIX platforms for entry points generated by `tools/maint/create_entry_points.py`. See: emscripten-core#10921
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that Windows launchers use
pylauncher.exe, shell script launchers are no longer needed on Windows for MINGW compatibility. We can revert the behavior from #10921 (commit 1c6e796) and use symbolic links on UNIX platforms for entry points generated bytools/maint/create_entry_points.py.See: #10921