Use await for loadDylibs#27079
Merged
Merged
Conversation
sbc100
force-pushed
the
dylink_async
branch
2 times, most recently
from
c98a2f8 to
52ec765
Compare
kripken
reviewed
Jun 10, 2026
kripken
reviewed
Jun 10, 2026
sbc100
added a commit
that referenced
this pull request
Jun 10, 2026
The loading of the dynamic libraries on startup has always been async but now we make a clear error to use `-sWASM_ASYNC_COMPILATION=0` with dynamic linking. Split out from #27079
This avoids the need for addRunDependency/removeRunDependency.
kripken
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids the need for addRunDependency/removeRunDependency.