Always await the createWasm promise under WASM_ASYNC_COMPILATION#27075
Merged
Conversation
When `WASM_ASYNC_COMPILATION` is enabled `createWasm` returns a promise. However we were not always waiting on this and instead using the `addRunDependency` system to block the running of main. This change simplifies things by always awaiting the promise when it exists. This is kind of a followup to emscripten-core#27059 and a pre-cursor to emscripten-core#27028 which is a much larger change.
brendandahl
approved these changes
Jun 9, 2026
Collaborator
Author
|
@kripken, just checking you are ok with the slow march towards using more modern async constructs. |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jun 9, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jun 9, 2026
Member
|
Direction lgtm! |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jun 9, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jun 9, 2026
sbc100
added a commit
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
WASM_ASYNC_COMPILATIONis enabledcreateWasmreturns a promise. However we were not always waiting on this and instead using theaddRunDependencysystem to block the running of main.This change simplifies things by always awaiting the promise when it exists.
This is kind of a followup to #27059 and a pre-cursor to #27028 which is a much larger change.
Comes with a nice little codesize saving too, since it avoid the whole
addRunDependencyin most simple programs.