Make more use of async/await for file packging#27034
Merged
Merged
Conversation
sbc100
force-pushed
the
loadPackage
branch
3 times, most recently
from
d95ebd3 to
354a06d
Compare
kripken
reviewed
Jun 1, 2026
sbc100
changed the title
sbc100
changed the title
…ependencies
Simplify the file packager and LZ4 loading code by leveraging modern
async/await features.
Previously, we tracked the loading of each individual preloaded file by
adding and removing separate run dependencies (`fp ${name}`). This
introduced complexity and extra boilerplate.
Now, we make `loadPackage` and `processPackageData` async functions and
directly `await` the preloading of each file (including running any
preload plugins). The main package-level run dependency
(`datafile_${name}`) is held until all files are fully processed and
then removed.
This reduces code complexity, eliminates the need for granular run
dependencies, and reduces the generated JS code size by ~100 bytes.
Split out from emscripten-core#27028
kripken
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the file packager and LZ4 loading code by leveraging modern
async/await features.
Previously, we tracked the loading of each individual preloaded file by
adding and removing separate run dependencies (
fp ${name}). Thisintroduced complexity and extra boilerplate.
Now, we make
loadPackageandprocessPackageDataasync functions anddirectly
awaitthe preloading of each file (including running anypreload plugins). The main package-level run dependency
(
datafile_${name}) is held until all files are fully processed andthen removed.
This reduces code complexity, eliminates the need for granular run
dependencies, and reduces the generated JS code size by ~100 bytes.
Split out from #27028