Skip to content

Update comment regarding default safari version #26813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Apr 29, 2026
+6 −10
Merged

Update comment regarding default safari version #26813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions site/source/docs/tools_reference/settings_reference.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2865,11 +2865,9 @@ MIN_SAFARI_VERSION
==================

Specifies the oldest version of desktop Safari to target. Version is encoded
in MMmmVV, e.g. 70101 denotes Safari 7.1.1.
Safari 14.1.0 was released on April 26, 2021, bundled with macOS 11.0 Big
Sur and iOS 14.5.
The previous default, Safari 12.0.0 was released on September 17, 2018,
bundled with macOS 10.14.0 Mojave.
in MMmmVV, e.g. 160101 denotes Safari 16.1.1.
Safari 15 was released on September 20, 2021, bundled with macOS 12.0
Monterey and iOS 15.
NOTE: Emscripten is unable to produce code that would work in iOS 9.3.5 and
older, i.e. iPhone 4s, iPad 2, iPad 3, iPad Mini 1, Pod Touch 5 and older,
see https://github.com/emscripten-core/emscripten/pull/7191.
Expand Down
8 changes: 3 additions & 5 deletions src/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1881,11 +1881,9 @@ var AUTO_NATIVE_LIBRARIES = true;
var MIN_FIREFOX_VERSION = 79;

// Specifies the oldest version of desktop Safari to target. Version is encoded
// in MMmmVV, e.g. 70101 denotes Safari 7.1.1.
// Safari 14.1.0 was released on April 26, 2021, bundled with macOS 11.0 Big
// Sur and iOS 14.5.
// The previous default, Safari 12.0.0 was released on September 17, 2018,
// bundled with macOS 10.14.0 Mojave.
// in MMmmVV, e.g. 160101 denotes Safari 16.1.1.
Copy link
Copy Markdown
Member

@kripken kripken Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well make this example have the currently supported version, to avoid confusion?

Copy link
Copy Markdown
Collaborator Author

@sbc100 sbc100 Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean I should use the default version here?

Copy link
Copy Markdown
Collaborator Author

@sbc100 sbc100 Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like including an example with minior numbers here.

Copy link
Copy Markdown
Member

@kripken kripken Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then perhaps something like x.y.z? I ask because I read this wrong the first time, I thought the example was the current version, especially as it appears first. I think an example equal to the current version, or newer, would be less confusing.

Anyhow, maybe it's just me. lgtm either way.

// Safari 15 was released on September 20, 2021, bundled with macOS 12.0
// Monterey and iOS 15.
// NOTE: Emscripten is unable to produce code that would work in iOS 9.3.5 and
// older, i.e. iPhone 4s, iPad 2, iPad 3, iPad Mini 1, Pod Touch 5 and older,
// see https://github.com/emscripten-core/emscripten/pull/7191.
Expand Down
Loading