Update test_duration in parallel testsuite#26804
Open
dschuff wants to merge 1 commit intoemscripten-core:mainfrom
Open
Update test_duration in parallel testsuite#26804dschuff wants to merge 1 commit intoemscripten-core:mainfrom
dschuff wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
This makes the "total core time" statistic correct on CI.
sbc100
reviewed
Apr 28, 2026
| result._mirrorOutput = False | ||
| finally: | ||
| result.elapsed = time.perf_counter() - start_time | ||
| result.test_duration = result.elapsed |
Collaborator
There was a problem hiding this comment.
How as this broken exactly?
Do we still need result.elapsed?
I notice we have an addDuration on the result here.. is that use called? Should we call it here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the "total core time" statistic correct on CI.