Skip to content

List the widget mark tests as layer-mode writers - #124

Merged
bobsingor merged 1 commit into
embedpdf/mainfrom
embedpdf/fix/widget-mark-layer-writers
Nov 17, 2026
Merged

bobsingor merged 1 commit into
embedpdf/mainfrom
embedpdf/fix/widget-mark-layer-writers

Conversation

@bobsingor

Copy link
Copy Markdown
Contributor

The release run after #123 failed in its layer-mode step (testing/tools/run_layer_mode.py): the five embedder tests #123 added write objects, and none of them was listed in testing/embedpdf_layer_mode_writers.txt.

error: leaves 2 objects in the layer but is not a known writer: EPDFFormEmbedderTest.ANegativeWidgetRotationIsDrawnAsItsTurn
error: leaves 7 objects in the layer but is not a known writer: EPDFStampResizeEmbedderTest.AQuarterTurnIsWrittenWithoutNoise
error: leaves 24 objects in the layer but is not a known writer: EPDFStampResizeEmbedderTest.AWidgetsMarkIsFittedIntoTheBoxItsTurnGives
error: leaves 24 objects in the layer but is not a known writer: EPDFStampResizeEmbedderTest.AWidgetsMarkWithoutAQuarterTurnFillsRect
error: leaves 8 objects in the layer but is not a known writer: EPDFStampResizeEmbedderTest.ATurnedWidgetsOwnAppearanceIsTurnedOnce

The change

Five lines in testing/embedpdf_layer_mode_writers.txt, in the file's sorted order, with the object counts the release run reported. No source or test changes.

Each of the five tests is a writer by what it tests: four place or wrap an appearance in a document made in memory, and one writes /MK /R into a loaded form and draws the field again.

Checked

On macOS arm64, with the embedder tests built from this tree:

python3 -I testing/tools/run_layer_mode.py out/embedpdf-runtime-tests-darwin-arm64 \
  --filter 'EPDFFormEmbedderTest.ANegativeWidgetRotationIsDrawnAsItsTurn:EPDFStampResizeEmbedderTest.AQuarterTurnIsWrittenWithoutNoise:EPDFStampResizeEmbedderTest.AWidgetsMark*:EPDFStampResizeEmbedderTest.ATurnedWidgetsOwnAppearanceIsTurnedOnce'
  • Before the change: the same five errors, with the same counts as the release run on Linux.
  • After it: exit 0, no errors, no warnings. All five pass in layer mode.

The full layer-mode run was not repeated here; the release run listed only these five errors.

The five embedder tests added with the widget mark placement and the
negative /MK /R fix write objects, so the release's layer-mode run
reported each as an unknown writer. Their lines are added with the
object counts that run reported.
@bobsingor
bobsingor merged commit d0edbb1 into embedpdf/main Nov 17, 2026
1 check passed
@bobsingor
bobsingor deleted the embedpdf/fix/widget-mark-layer-writers branch November 17, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant