Repository navigation
List the widget mark tests as layer-mode writers - #124
Merged
Merged
Conversation
The five embedder tests added with the widget mark placement and the negative /MK /R fix write objects, so the release's layer-mode run reported each as an unknown writer. Their lines are added with the object counts that run reported.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release run after #123 failed in its layer-mode step (
testing/tools/run_layer_mode.py): the five embedder tests #123 added write objects, and none of them was listed intesting/embedpdf_layer_mode_writers.txt.The change
Five lines in
testing/embedpdf_layer_mode_writers.txt, in the file's sorted order, with the object counts the release run reported. No source or test changes.Each of the five tests is a writer by what it tests: four place or wrap an appearance in a document made in memory, and one writes
/MK /Rinto a loaded form and draws the field again.Checked
On macOS arm64, with the embedder tests built from this tree:
The full layer-mode run was not repeated here; the release run listed only these five errors.