Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@v7

- name: Install pnpm
uses: pnpm/action-setup@v6
uses: pnpm/action-setup@v6.0.9
Comment on lines 20 to +21

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving the duplication as-is. YAML anchors aren't supported in Actions workflow files, so the only real options are a reusable workflow or a local composite action — and for three steps across two jobs, that indirection costs more in readability and Dependabot coverage (a nested action.yml needs its own directories entry in dependabot.yml) than the drift risk it removes. Worth revisiting if a third job appears.


- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v7
Comment on lines 18 to 24

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — addressed in #83, which pins all three actions (actions/checkout, pnpm/action-setup, actions/setup-node) to full commit SHAs with trailing version comments rather than mixing exact versions and floating major tags. Closing this PR in favor of that one.

Expand All @@ -44,7 +44,7 @@ jobs:
uses: actions/checkout@v7

- name: Install pnpm
uses: pnpm/action-setup@v6
uses: pnpm/action-setup@v6.0.9
Comment on lines 46 to +47

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving the duplication as-is. YAML anchors aren't supported in Actions workflow files, so the only real options are a reusable workflow or a local composite action — and for three steps across two jobs, that indirection costs more in readability and Dependabot coverage (a nested action.yml needs its own directories entry in dependabot.yml) than the drift risk it removes. Worth revisiting if a third job appears.


- name: Use Node.js
uses: actions/setup-node@v7
Comment on lines 46 to 50

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — addressed in #83, which pins all three actions (actions/checkout, pnpm/action-setup, actions/setup-node) to full commit SHAs with trailing version comments rather than mixing exact versions and floating major tags. Closing this PR in favor of that one.

Expand Down