Support processing HTTP/1.1 headers as they arrive - #499
Open
gdwoolbert3 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
This is my attempt at implementing the feature requested in Issue 452.
The motivating for the change was the
X-ClickHouse-Progressheader system used by the ClickHouse HTTP interface (which I strongly suspect was the reason behind the aforementioned issue).Implementation
This PR adds a new
:stream_headersoption for HTTP/1.1 connections that allows headers and trailers to be emitted as responses as soon as they're available instead of buffering them until they've all arrived. A few nuances about enabling this feature::headersresponses for a given request whereas, when not streaming headers, an empty list would be emitted. This change is explicitly laid out in theMint.HTTPdocumentation.This feature is opt-in, meaning there should be no changes for existing users.
Tesing
All existing tests pass and new stream headers tests were added to the HTTP/1.1 connection test module.
Open to any and all feedback 馃槂