Skip to content

Indicator: show accels if available - #312

Merged
danirabbit merged 5 commits into
mainfrom
danirabbit/indicator-accels
Aug 30, 2026
Merged

Indicator: show accels if available#312
danirabbit merged 5 commits into
mainfrom
danirabbit/indicator-accels

Conversation

@danirabbit

@danirabbit danirabbit commented Aug 27, 2026

Copy link
Copy Markdown
Member

@danirabbit
danirabbit requested a review from a team August 27, 2026 17:20
@danirabbit danirabbit added this to A11y Aug 27, 2026
@github-project-automation github-project-automation Bot moved this to Needs Review in A11y Aug 27, 2026
@danirabbit
danirabbit marked this pull request as draft August 27, 2026 17:33
@danirabbit danirabbit moved this from Needs Review to In Progress in A11y Aug 27, 2026
@danirabbit
danirabbit marked this pull request as ready for review August 27, 2026 18:40
@danirabbit danirabbit added this to OS 9 Aug 27, 2026
@danirabbit danirabbit moved this to Needs Review in OS 9 Aug 27, 2026
@danirabbit danirabbit moved this from In Progress to Needs Review in A11y Aug 28, 2026

@jeremypw jeremypw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as expected.

I wonder whether the tooltip would look more balanced if the accels were right-aligned inline with the description rather the usual position for a twoline tool tip? Not blocking though.

@danirabbit
danirabbit merged commit 36b245d into main Aug 30, 2026
2 of 4 checks passed
@danirabbit
danirabbit deleted the danirabbit/indicator-accels branch August 30, 2026 13:34
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in OS 9 Aug 30, 2026
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in A11y Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants