Skip to content

Feature: Add action to find matching bracket - #1680

Open
jeremypw wants to merge 19 commits into
masterfrom
jeremypw/goto-matching-action
Open

Feature: Add action to find matching bracket#1680
jeremypw wants to merge 19 commits into
masterfrom
jeremypw/goto-matching-action

Conversation

@jeremypw

@jeremypw jeremypw commented Nov 24, 2025

Copy link
Copy Markdown
Collaborator

Builtin highlight matching brackets only works over a limited number of characters. This works over whole document, scrolls to match and checks whether indent is the same.

This action (but not accelerator) is now exposed in the document context menu

@jeremypw jeremypw added the testing Merged in code-dogfood project. Does not conflict with other PRs with testing label. label Jan 25, 2026
@jeremypw jeremypw removed the testing Merged in code-dogfood project. Does not conflict with other PRs with testing label. label May 16, 2026
@jeremypw jeremypw modified the milestones: 8.3.1, 8.4 May 16, 2026
@jeremypw jeremypw changed the title Add action to find matching bracket Feature: Add action to find matching bracket Jun 20, 2026
@jeremypw jeremypw modified the milestones: 8.4, 8.5 Aug 9, 2026
@jeremypw
jeremypw marked this pull request as ready for review August 9, 2026 15:37
@danirabbit
danirabbit requested a review from a team August 9, 2026 16:52
zeebok
zeebok previously approved these changes Aug 27, 2026

@zeebok zeebok left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one optional comment but looks good to me! Excited to make use of this feature!

Comment thread src/Widgets/SourceView.vala Outdated
@jeremypw

jeremypw commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

I'd like to add extra functionality to find where the error occured if possible but that will have to wait for another PR. I'd also like to expose the shortcut somehow but the document context menu does not currently show accels. Again, another PR.

@jeremypw
jeremypw requested a review from zeebok August 28, 2026 13:59
@zeebok

zeebok commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

I'd like to add extra functionality to find where the error occured if possible but that will have to wait for another PR. I'd also like to expose the shortcut somehow but the document context menu does not currently show accels. Again, another PR.

I wonder if adding a Cheat Sheet option in the gear menu that gives a bunch of helpful shortcuts and features is a decent enough way to expose it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants