Skip to content

Pin pyasn1 >=0.6.4 to address transitive DoS advisories - #2314

Closed
devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
devin/1785995231-pin-pyasn1
Closed

Pin pyasn1 >=0.6.4 to address transitive DoS advisories#2314
devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
devin/1785995231-pin-pyasn1

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds an explicit pyasn1 = ">=0.6.4,<0.7" constraint to close the three open high-severity Dependabot alerts on pyproject.toml (BER/CER/DER decoder DoS via unbounded long-form tag IDs, quadratic OID processing, unbounded resource use decoding REAL values).

pyasn1 is transitive only (google-cloud-storagegoogle-authpyasn1-modules >=0.2.1pyasn1 >=0.6.1,<0.7). Since this repo ships no lockfile, the pre-0.6.4 versions the range still admits are what Dependabot flags, so the fix is a manifest-level floor — same pattern already used for idna. Upper bound kept at <0.7 to match pyasn1-modules' own constraint. poetry lock resolves cleanly with the pin.

Link to Devin session: https://app.devin.ai/sessions/b110c025432048528cdfc46e55ffb1ef

Summary by CodeRabbit

  • Security
    • Updated a security-related dependency constraint to address decoder denial-of-service advisories.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

👋 @devin-ai-integration[bot]
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6208e257-e6da-4f39-9469-35a923c460f2

📥 Commits

Reviewing files that changed from the base of the PR and between 594b89d and 8099e66.

📒 Files selected for processing (1)
  • pyproject.toml

📝 Walkthrough

Walkthrough

The project adds pyasn1 as a direct runtime dependency, constrained to versions >=0.6.4 and <0.7.

Changes

Runtime dependency update

Layer / File(s) Summary
pyasn1 dependency declaration
pyproject.toml
Adds pyasn1>=0.6.4,<0.7 as a runtime dependency.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: arbiv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the dependency constraint added to address transitive denial-of-service advisories.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch devin/1785995231-pin-pyasn1

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate — #2310 already contains this exact change (identical pyasn1 >=0.6.4,<0.7 pin) with green CI, and is just waiting on review. Please review/merge that one instead.

@devin-ai-integration
devin-ai-integration Bot deleted the devin/1785995231-pin-pyasn1 branch August 6, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants