Merge pull request #2279 from elementary-data/release/v0.25.0#2280
Closed
github-actions[bot] wants to merge 838 commits into
Closed
Merge pull request #2279 from elementary-data/release/v0.25.0#2280github-actions[bot] wants to merge 838 commits into
github-actions[bot] wants to merge 838 commits into
Conversation
…ailed-teams-webhook Added more detailed exception for teams webhook failure
* report: disable_samples should only affect dbt tests * update package dependency in CLI dbt project * update package lock * return old comment * remove name from package lock * update dbt package version * update package-lock * disable_samples - preserve previous behavior for dbt tests by setting to None
* Correctly shorten versioned model name
…robatching (#2041) * add support for partial success * tweaks * fix unit tests
…ys, upgrade to v10 (#2045)
…n in message sending
…-resolution-notifications-in-channel Enhance SlackWebMessagingIntegration to support reply_broadcast optio…
…uments in from_token method
…-resolution-notifications-in-channel Enhance SlackWebMessagingIntegration to accept additional keyword arg…
…_scan Fix BigQuery scan for test result rows
Co-authored-by: mika <mika@elementary-data.com>
This commit introduces HTML formatting for messages, including support for various blocks like headers, text, lists, tables, and expandable sections. It also adds comprehensive unit tests with corresponding HTML fixtures to ensure correct rendering. Co-authored-by: mika <mika@elementary-data.com>
- Added comprehensive test coverage for all block types (TableBlock, CodeBlock, DividerBlock, ActionsBlock) - Improved fact list styling: removed backgrounds/borders, added max-width:200px on labels - Standardized font-size to 14px across all blocks (fact lists, tables, expandable) - Removed ActionsBlock rendering (not supported in HTML emails, matches adaptive cards) - Made expandable blocks actually expandable using HTML5 details/summary elements - Added visual arrow indicators (▶/▼) to expandable blocks, properly hiding native browser triangles - Enhanced bullet lists with proper semantic HTML (ul/li elements) and automatic pattern detection - All 36 HTML formatter tests passing
CSS property syntax (colons and semicolons in style strings) triggers false positive flake8 E231 and E702 errors. Added noqa comments to suppress these warnings for legitimate CSS syntax within Python string literals.
- Add 800px max-width to main container for better readability - Update container padding to 24px top, 32px left/right, 32px bottom - Match all borders to status color (red/yellow/green) when color is set - Adjust left padding to 28px when colored border is applied (to account for 4px thicker left border) - Set fact list (questions/answers) left column to fixed 160px width - Add 8px extra top and bottom margin to fact list blocks - Add max-height (400px) and scroll to code blocks to prevent excessive vertical space - Fix expandable block arrow to rotate 90° when opened (▶ → ▼) with smooth transition - Update test fixtures to reflect all design changes - Add code_block_long.html fixture to demonstrate scrollable code blocks These changes only affect HTML email formatting and do not impact Slack (Block Kit) or Teams (Adaptive Cards) integrations.
- Corrected string formatting for CSS styles in HTML output - Simplified inline space handling logic in bullet lists - Added flake8 noqa comments to suppress style warnings for CSS syntax These changes enhance the maintainability of the HTML formatter without altering its functionality.
- Update fixtures for all formats (HTML, Adaptive Cards, Block Kit, Markdown, Text) - Reflects enhanced base test suite with additional blocks: - CodeBlock with multi-line code samples - DividerBlock for visual separation - TableBlock with headers and multiple columns - ActionsBlock with dropdown and user select components - Additional inline blocks (MentionBlock, InlineCodeBlock) - All 198 message format tests passing
- Extract all inline CSS styles to named class constants - Split large methods into smaller, focused helper methods - Add reusable helper methods for common patterns: - _skip_whitespace() for navigating inline blocks - _is_bullet_marker() for identifying bullet markers - _extract_bullet_parts() for parsing bullet list lines - _format_bullet_list_item() for formatting list items - Split block formatting into dedicated methods: - _format_header_block(), _format_code_block(), _format_divider_block() - _format_link_block(), _format_inline_code_block(), _format_mention_block() - _format_table_header(), _format_table_body(), _format_table_row() - _build_expandable_summary() for expandable block arrows No functional changes - all 36 HTML format tests passing All pre-commit checks passing (black, isort, flake8, mypy)
…l-formatter-81ef Create html email formatter
…ore-113-remove-deprecated-dags
…ted-dags Remove deprecated test recommendations macro
Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid installing the full project; 1.8 is the first supported dbt version. Co-authored-by: Cursor <cursoragent@cursor.com>
Use peter-evans/create-pull-request v8 for release and docs PR creation. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove add-paths so create-pull-request includes every modified file by default. Co-authored-by: Cursor <cursoragent@cursor.com>
Show CLI and dbt package versions in the bump-version commit message and PR title. Co-authored-by: Cursor <cursoragent@cursor.com>
…orkflow CORE-918: Improve bump-version workflow for docs branch and dbt lock
Support custom paths for internal dbt project via env vars
Co-authored-by: Cursor <cursoragent@cursor.com>
…-report-bundle chore: add report bundle 1.0.34
Co-authored-by: Cursor <cursoragent@cursor.com>
Release v0.24.1 (dbt package v0.24.0)
…ary-package chore: Update dbt package
…1.10.1 dbt-dremio 1.10.1 changed TABLE schema resolution to use +root_path instead of +schema. Without +root_path set, tables fall back to target.root_path directly, landing at 'elementary_tests' instead of 'elementary_tests.elementary'. The CLI profile hardcodes 'elementary_tests.elementary', causing 'object not found' errors. Adding +root_path: elementary makes tables land at the same path in both 1.10.0 and 1.10.1. Co-authored-by: Cursor <cursoragent@cursor.com>
fix(dremio): add +root_path to e2e project to fix CI with dbt-dremio 1.10.1
Co-authored-by: Cursor <cursoragent@cursor.com>
…d-report-bundle chore: update report bundle to v1.0.35
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Release v0.25.0 (dbt package v0.25.0)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
95
to
+101
| - name: Checkout Elementary | ||
| uses: actions/checkout@v3 | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| path: elementary | ||
| ref: ${{ inputs.elementary-ref }} | ||
|
|
||
| - name: Configure AWS credentials |
Comment on lines
107
to
+114
| - name: Checkout dbt package | ||
| uses: actions/checkout@v3 | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| repository: elementary-data/dbt-data-reliability | ||
| path: dbt-data-reliability | ||
| ref: ${{ inputs.dbt-data-reliability-ref }} | ||
|
|
||
| - name: Validate workflow inputs |
| @staticmethod | ||
| def run(cmd: list[str], check: bool = True, **kw: object) -> subprocess.CompletedProcess: # type: ignore[type-arg] | ||
| """Run a command, printing it first.""" | ||
| print(f" -> {shlex.join(cmd)}") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v0.25.0 (dbt package v0.25.0)