feat: simplify Show4DSTEM dataset comparison - #222
Merged
bobleesj merged 1 commit intoAug 12, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does it solve?
Opening one 4D-STEM master and comparing several compatible masters required users to understand internal layout parameters. The common workflow is now the same in both cases:
load(...), thenShow4DSTEM(data). A loaded 5D stack opens in Multiple view with filename labels and Selected diffraction mode automatically.What should reviewer(s) do?
Review the new one-dataset and multi-dataset guides. Confirm that
Show4DSTEM(load([master1, master2]))opens the comparison view without extra layout parameters, then switch Selected to Average and back to Selected.Verification
npm run build31 passedintests/show4dstem/test_factory.py1118 passed, 20 skipped, 1 unrelated ShowPtycho failurecaused by the external localquantem.gpucheckout mismatchjupyter-book build docsThis PR follows the scikit-package workflow for reproducible scientific software.