Skip to content

fix: keep Show3D histograms live and publish docs - #217

Merged
bobleesj merged 3 commits into
electronmicroscopy:mainfrom
bobleesj:aug-10-show3d-live-histogram
Aug 11, 2026
Merged

fix: keep Show3D histograms live and publish docs#217
bobleesj merged 3 commits into
electronmicroscopy:mainfrom
bobleesj:aug-10-show3d-live-histogram

Conversation

@bobleesj

Copy link
Copy Markdown
Collaborator

Summary

  • Keep independent Show3D panel histograms synchronized with resident playback frames and repaint contrast edits without stopping playback.
  • Unblock the GitHub Pages build so the merged Show4DSTEM GIF and Serin Lee acknowledgment reach the hosted documentation.
  • Replace the repeated scikit-package paper citation in the PR template with one concise project-workflow link.

Verification

  • npm run build
  • npm run typecheck
  • npm test: 132 passed
  • PYTHONPATH=src pytest -q tests/show3d in live-env: 87 passed, 1 skipped
  • Full suite: 1114 passed, 16 skipped; 2 unrelated environment-version failures in ShowPtycho provenance and MPS tests
  • Jupyter Book built all 59 pages; ShowDiffraction source remained published but was excluded from execution; navigation check passed all 62 generated pages
  • Built intro contains the Show4DSTEM GIF and acknowledgment, with matching _images and _static GIF assets
  • Phil Chrome on Apple WebGPU: synthetic three-panel and real Caitlyn two-panel stacks stayed resident; histogram curves changed during playback; a same-frame contrast edit repainted in 15 ms while playback remained active

Core checklist

  • Focused frontend and browser regression coverage added
  • Worktree status and staged diff inspected; no generated reports, screenshots, private data, or notebook state committed
  • No notebooks changed

This PR follows the scikit-package workflow for reproducible scientific software.

@bobleesj
bobleesj force-pushed the aug-10-show3d-live-histogram branch from a6e7ac9 to 09712d2 Compare August 11, 2026 04:31
@bobleesj bobleesj changed the title Fix Show3D live histograms and docs publishing fix: keep Show3D histograms live and publish docs Aug 11, 2026
@bobleesj
bobleesj merged commit 648f905 into electronmicroscopy:main Aug 11, 2026
1 check passed
@bobleesj
bobleesj deleted the aug-10-show3d-live-histogram branch August 11, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant