Add ShowDiffraction detection denoise - #207
Open
henryhng wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detection-level denoise for ShowDiffraction.
Verification
PYTHONPATH=src pytest -q(1099 passed, 0 failed),npm run build,npm test(123 passed),npm run typecheckCore checklist (every PR)
frontend build coverage where possible; start with
PYTHONPATH=src:. pytest -qand
npm run build, or runscripts/widget_local_signoff.sh.git status --shortandgit diff --stat;do not commit generated HTML, docs builds, screenshots, local notebooks,
private data, or machine-specific notes.
metadata.widgets) andpass
scripts/check_notebook_sizes.py.deleted from this description.
Python API and docs — new widget, loader, or API change
CHANGELOG.md; README/API index unchanged (existing widget).This PR workflow follows the packaging standards for reproducible scientific
software described in scikit-package:
S. Lee, C. Myers, A. Yang, T. Zhang, Y. Xiao, and S. J. L. Billinge,
Digital Discovery (2026), DOI
10.1039/d6dd00121a.