feat: isolate run button#1952
Open
dsanders11 wants to merge 2 commits into
Open
Conversation
Assisted-by: Claude Opus 4.7
|
coverage: 87.403% (-0.9%) from 88.301% — refactor/isolate-zee-run-button-now into main |
ckerr
reviewed
May 22, 2026
Comment on lines
+85
to
+89
| if (location.protocol === ISOLATED_ACTIONS_PROTOCOL) { | ||
| setupIsolatedActionsGlobal(); | ||
| } else { | ||
| await setupFiddleGlobal(); | ||
| } |
Member
There was a problem hiding this comment.
Let's add an isMainFrame check here, exposing only isolated if we're not the main frame
Suggested change
| if (location.protocol === ISOLATED_ACTIONS_PROTOCOL) { | |
| setupIsolatedActionsGlobal(); | |
| } else { | |
| await setupFiddleGlobal(); | |
| } | |
| if (isMainAppFrame()) { | |
| await setupFiddleGlobal(); | |
| } else { | |
| setupIsolatedActionsGlobal(); | |
| } |
Member
Author
There was a problem hiding this comment.
Not sure about this change, only because in the future there may be another protocol that'll need different a different preload as well. If we isolate the editors themselves, they'll need additional third-party code (monaco-editor, etc) so we'll want to separate those as well. I think going off the protocol here will scale better for future changes.
Assisted-by: Claude Opus 4.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isolates the run button to a cross-origin iframe to ensure it's rendered as an out-of-process iframe (OOPIF), and is isolated in a separate process to protect against a compromised renderer. This prevents the renderer from being able to programmatically run fiddles, and only the main process or user interaction can start them.