fix: preserve host process.exitCode when closing PGlite#1059
Open
zakcutner wants to merge 1 commit into
Open
Conversation
close() calls _emscripten_force_exit(0), whose Emscripten runtime sets process.exitCode = 0 and clobbers any exit code the host process had already set. Save and restore process.exitCode around the call, matching the existing guards in #init() and execProtocolRaw().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a PGlite instance resets the host process's
process.exitCodeto0. This wipes out whatever the host had already set.The cause is
close()calling_emscripten_force_exit(0). Emscripten implements exit asquit_ = (e, r) => { throw process.exitCode = e, r }, so it writesprocess.exitCode = 0on the host Node process. The#init()andexecProtocolRaw()paths already save and restoreprocess.exitCodearound their Emscripten calls, butclose()was missing the same guard.This adds that guard. It reuses the existing
pglUtils.pgliteProc.exitCodesave and restore pattern in afinally, likeexecProtocolRaw(). It also adds a test next to the existingrestores process.exitCodeone, plus a changeset.