Skip to content

gcs-mock-service: fix bucket created once per file instead of once per bucket - #20882

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:gcs-mock-fix
Aug 26, 2026
Merged

gcs-mock-service: fix bucket created once per file instead of once per bucket#20882
efd6 merged 1 commit into
elastic:mainfrom
efd6:gcs-mock-fix

Conversation

@efd6

@efd6 efd6 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

gcs-mock-service: fix bucket created once per file instead of once per bucket

processManifest called createBucket inside the per-file loop, so any
bucket configured with more than one file would fail on the second file
with "bucket already exists" and exit with code 1. Move the call outside
the inner loop so the bucket is created once per bucket entry.

Note

No changelogs since this is not user-facing.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

…r bucket

processManifest called createBucket inside the per-file loop, so any
bucket configured with more than one file would fail on the second file
with "bucket already exists" and exit with code 1. Move the call outside
the inner loop so the bucket is created once per bucket entry.
@efd6 efd6 self-assigned this Aug 25, 2026
@efd6 efd6 added Integration:netskope Netskope Integration:cloudflare_logpush Cloudflare Logpush bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:symantec_endpoint_security Symantec Endpoint Security skip-changelog labels Aug 25, 2026
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

cc @efd6

@efd6
efd6 marked this pull request as ready for review August 25, 2026 09:47
@efd6
efd6 requested review from a team as code owners August 25, 2026 09:47
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@vera-review-bot

Copy link
Copy Markdown

🟢 No issues across the latest commits 1c0d568.

A new commit triggers another review — at most once every 15 minutes. I skip the PR while it's approved or has merge conflicts.

🤖 AI-Generated Review | Vera Review Bot - v0.2.7 | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

@ShourieG ShourieG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix.

@efd6
efd6 merged commit 70ff7c9 into elastic:main Aug 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cloudflare_logpush Cloudflare Logpush Integration:netskope Netskope Integration:symantec_endpoint_security Symantec Endpoint Security skip-changelog Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants