[Filestream] Always render boolean options with default true - #20876
[Filestream] Always render boolean options with default true#20876belimawr wants to merge 2 commits into
Conversation
Some options that have true as default were only rendered if set to true preventing uses from setting it to false, which effectively renders the UI toggle useless. This commit fixes it by always rendering those options, no matter if they're set to true or false. Assisted-by: gpt-5.6-terra-high
b18e63c to
8defb63
Compare
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
There was a problem hiding this comment.
Pull request overview
Updates Filestream policy rendering so boolean options defaulting to true are explicitly rendered and can be set to false.
Changes:
- Adds the
clean_removed: truedefault and bumps the package version. - Always renders
recursive_globandclean_removed. - Adds changelog documentation and policy tests for defaults and false overrides.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Summary |
|---|---|
packages/filestream/manifest.yml |
Adds the clean_removed default and updates the version. |
packages/filestream/changelog.yml |
Documents the bug fix. |
packages/filestream/agent/input/filestream.yml.hbs |
Always renders both boolean options. |
packages/filestream/_dev/test/policy/test-true-defaults.yml |
Tests default values. |
packages/filestream/_dev/test/policy/test-true-defaults.expected |
Verifies rendered true defaults. |
packages/filestream/_dev/test/policy/test-false-overrides.yml |
Tests false overrides. |
packages/filestream/_dev/test/policy/test-false-overrides.expected |
Verifies rendered false values. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
✅ All changelog entries have the correct PR link. |
💚 Build Succeeded
cc @belimawr |
|
Tick the box to add this pull request to the merge queue (same as
|
Proposed commit message
Checklist
changelog.ymlfile.I have verified that any added dashboard complies with Kibana's Dashboard good practices## Author's ChecklistHow to test this PR locally
Run the tests
Manual test
1. Verify default values in Kibana
Create a Filestream package policy without overriding
recursive_globorclean_removed. In Kibana, use the agent policy's View policy option and locate the generatedfilestreaminput.Expected: the rendered policy contains
prospector.scanner.recursive_glob: trueandclean_removed: true.2. Verify disabled values are rendered
Disable the toggle for 'Recursive Glob' and 'Recursive Glob'.
Expected: the rendered policy contains
prospector.scanner.recursive_glob: falseandclean_removed: false.## Related issues## Screenshots