Skip to content

Docs: reserve space for applies-block before hydration - #3790

Open
reakaleek wants to merge 1 commit into
mainfrom
fix/applies-block-layout-shift
Open

Docs: reserve space for applies-block before hydration#3790
reakaleek wants to merge 1 commit into
mainfrom
fix/applies-block-layout-shift

Conversation

@reakaleek

Copy link
Copy Markdown
Member

What

  • Add a minimum height to block-level applies badges so the row keeps its space before the web component loads
  • Prevent content below the page title from jumping when applies badges appear

Why

  • Empty <applies-to-popover> elements render no visible badge until JavaScript loads
  • The first applies block on pages like /docs/get-started/the-stack caused a layout shift of about 30px

Notes

  • Uses the same reserved-space pattern as the global nav wrapper in assembler.css
  • Applies to all block-level applies emitters through the shared .applies.applies-block class

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>

@Mpdreamz Mpdreamz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layout shifts are nasty, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants