Skip to content

Add trace context in Sidekiq to connect request transaction and worker in the one trace - #1456

Merged
smith merged 6 commits into
elastic:mainfrom
dixent:sidekiq_request_same_trace
Aug 11, 2026
Merged

Add trace context in Sidekiq to connect request transaction and worker in the one trace#1456
smith merged 6 commits into
elastic:mainfrom
dixent:sidekiq_request_same_trace

Conversation

@dixent

@dixent dixent commented May 10, 2024

Copy link
Copy Markdown
Contributor

What does this pull request do?

  1. Adding transaction trace context in the Sidekiq job.
  2. Use transaction trace context when creating transactions for Sidekiq job by the Sidekiq server.

Why is it important?

Connection of transactions in one trace is necessary to display data in Kibana. It allows jumping from one transaction to another even if one worker calls another.

image

Checklist

  • I have signed the Contributor License Agreement.
  • My code follows the style guidelines of this project (See .rubocop.yml)
  • I have rebased my changes on top of the latest main branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Related issues

https://discuss.elastic.co/t/distributed-traces-on-background-jobs/256555

@cla-checker-service

cla-checker-service Bot commented May 10, 2024

Copy link
Copy Markdown

💚 CLA has been signed

@dixent dixent changed the title [WIP] Add trace context in Sidekiq to connect request transaction and worker in the one trace Add trace context in Sidekiq to connect request transaction and worker in the one trace May 10, 2024
@dixent

dixent commented May 16, 2024

Copy link
Copy Markdown
Contributor Author

I am sorry, I am waiting assist from my company management regarding CLA.

@dixent

dixent commented Jun 11, 2024

Copy link
Copy Markdown
Contributor Author

Ready for review!

@smith
smith merged commit f8286df into elastic:main Aug 11, 2026
56 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in APM-Agents (OLD) Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants