feat: validate Flux bootstrap flags before creating the cluster#8771
Open
JesusZuluaga-M wants to merge 1 commit into
Open
feat: validate Flux bootstrap flags before creating the cluster#8771JesusZuluaga-M wants to merge 1 commit into
JesusZuluaga-M wants to merge 1 commit into
Conversation
Contributor
|
Hello JesusZuluaga-M 👋 Thank you for opening a Pull Request in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3664
I think this may resolve this issue.
Currently
eksctl create clusteronly discovers invalidgitops.flux.flagswhenit calls
flux bootstrapat the very end of the process — after the cluster hasalready taken ~25 minutes to provision. This PR validates those flags upfront,
before cluster creation starts.
Flux has no dry-run mode for
bootstrap, so the validation uses the workaroundsuggested in the issue: it builds the same args
Bootstrap()would use and appendsa sentinel flag that Flux can never recognise (
--eksctl-internal-validate-only).Since Flux's flag parser (
pflag) stops at the first unrecognised flag:Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯