fix: make Space and Project deletion permanent - #1850
Draft
xdCloudy wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #1793
Description
Deleting a Project currently removes its task/history state from the UI but can leave the durable
Projectrow behind. Deleting a Space then fails withspace_has_projects, even though the Space deletion confirmation says the Space and all of its Projects will be permanently deleted.This change makes the destructive actions match that UI contract.
Root cause
SpaceService.delete_space()rejects any Space that still has Project rows, including archived Projects.ChatHistoryremoves triggers but does not remove the durableProjectrow.Changes
DELETE /spaces/{space_id}/projects/{project_id}for direct Project deletionThe cleanup covers chat histories, trigger executions/triggers, Project/Space memory, pending file overlays, and Space file-index rows before removing the parent records.
Testing
Regression tests are included in
server/tests/test_space_project_deletion.pyfor:Manual reproduction was on Windows: Project deletion appeared to succeed in the UI, but the remaining server Project row caused subsequent Space deletion to fail. This PR is currently a draft pending branch test/CI results.
What is the purpose of this pull request?
Contribution Guidelines Acknowledgement