Skip to content

feat: spack install --source for select packages#46

Open
wdconinc wants to merge 1 commit into
masterfrom
spack-install-source
Open

feat: spack install --source for select packages#46
wdconinc wants to merge 1 commit into
masterfrom
spack-install-source

Conversation

@wdconinc

Copy link
Copy Markdown
Contributor

Briefly, what does this PR introduce?

This PR enables storing of source used for compilation of products in the container, for ease of debug symbol interpretation.

What kind of change does this PR introduce?

  • Bug fix (issue: debug builds point to source in stage path)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Copilot AI review requested due to automatic review settings November 19, 2025 15:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables the storage of source code used during compilation for select packages in the container environment. This addresses a bug where debug builds incorrectly point to temporary source paths in the stage directory, making debug symbol interpretation difficult.

  • Adds package_attributes: install_source: true configuration to 7 key packages
  • Ensures source code is retained in the container for debugging purposes
  • Targets packages that are commonly debugged: acts, dd4hep, eicrecon, epic, irt, jana2, and podio

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc force-pushed the spack-install-source branch from 53c8f6a to 175a179 Compare April 29, 2026 02:11
@wdconinc wdconinc enabled auto-merge (squash) April 29, 2026 02:12
Copilot AI review requested due to automatic review settings May 16, 2026 21:50
@wdconinc wdconinc force-pushed the spack-install-source branch from 175a179 to 0261c6b Compare May 16, 2026 21:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants