Draft
Add spack.lock artifact storage and spack diff comparison in PR CI#385
Conversation
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
wdconinc
August 8, 2026 22:35
View session
Copilot stopped work on behalf of
wdconinc due to an error
August 8, 2026 23:06
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
wdconinc
reviewed
Aug 9, 2026
| name: eic-${{ matrix.ENV }}-${{ matrix.arch }}-nightly-digest | ||
| path: /tmp/digests/${{ matrix.arch }}-nightly.digest | ||
| retention-days: 1 | ||
| - name: Export spack.lock files |
Contributor
There was a problem hiding this comment.
@copilot We do not want to build another container (and duplicate locally all common args; which is tech debt risking going out of sync). Just docker cp the relevant lock file out of the container.
Contributor
Author
There was a problem hiding this comment.
Done — replaced the second docker buildx build with docker create + docker cp + docker rm using the image digest from /tmp/build-metadata-default.json. The scratch-based export stages in the Dockerfile have also been removed since they're no longer needed. Committed in the latest push.
…lock files Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
wdconinc
added
the
pre-commit.ci autofix
pre-commit-ci
Bot
removed
the
pre-commit.ci autofix
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR CI currently gives no visibility into how the spack environment changes. This adds spack.lock extraction as pipeline artifacts and compares new vs. base-branch lock files using
spack diffin PR builds.eicjob — extract and upload spack.lock artifactsAfter the main build, a temporary container is created from the already-pushed image digest using
docker create, anddocker cpis used to pull the spack.lock files out — no second build is needed. Produces:default.spack.lock— always (all envs/targets)custom.spack.lock— only whentarget == final(ci, xl)Artifacts named
spack-lock-{ENV}-{arch}, retained 90 days (sufficient for cross-PR comparison against master).New
spack-diffjob (PR/merge-group only)Runs after
eic-manifestinside theeic_cicontainer (has spack). Matrix:ciandxlonamd64.dawidd6/action-download-artifact)spack diff pkg@old pkg@newfor detailed spec-tree output (withcontinue-on-error)Diff output is visible only in pipeline logs; no artifacts published.