feat: add ZeroLineProperties support to ColumnChart and RowChart#171
Open
saadkhalidkhan wants to merge 4 commits into
Open
feat: add ZeroLineProperties support to ColumnChart and RowChart#171saadkhalidkhan wants to merge 4 commits into
saadkhalidkhan wants to merge 4 commits into
Conversation
Add zero line support for column charts with negative values, matching the existing LineChart ZeroLineProperties API including animation and under/above z-order.
Add vertical zero line support for row charts with negative values, using the same ZeroLineProperties model and animation as LineChart.
Show ZeroLineProperties on ColumnSample3 and RowSample3 which already use mixed positive and negative bar data.
Add zero line usage examples to the column and row chart guides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zeroLinePropertiesparameter toColumnChartandRowChart, reusing the existingZeroLinePropertiesmodel fromLineChartZType.UnderandZType.Abovelayering, matchingLineChartbehaviorColumnSample3,RowSample3)Closes #161
Commits
feat(ColumnChart): add ZeroLineProperties parameter and drawingfeat(RowChart): add ZeroLineProperties parameter and drawingdemo: enable zero line in negative-value chart samplesdocs: document ZeroLineProperties for column and row chartsTest plan
:compose-charts:compileDebugKotlinAndroidbuilds successfully:app:compileDebugKotlinAndroidbuilds successfullyzeroLinePropertiesare unchanged (default disabled)