feat: add pretty run report #416
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from collections.abc import Callable | ||
| from dataclasses import dataclass, field | ||
| from datetime import timedelta | ||
|
|
||
| from . import bindings | ||
| from .declarations import CommandDecl, Declarations | ||
| from .egraph_state import EGraphState | ||
| from .pretty import pretty_decl | ||
|
|
||
|
|
||
| def _format_rule_key(decls: Declarations, key: CommandDecl | str) -> str: | ||
| if isinstance(key, str): | ||
| return key | ||
| return pretty_decl(decls, key) | ||
|
|
||
|
|
||
| @dataclass | ||
| class RuleReport: | ||
| plan: bindings.Plan | None | ||
| search_and_apply_time: timedelta | ||
| num_matches: int | ||
|
|
||
| @classmethod | ||
| def _from_bindings(cls, report: bindings.RuleReport) -> RuleReport: | ||
| return cls( | ||
| plan=report.plan, | ||
| search_and_apply_time=report.search_and_apply_time, | ||
| num_matches=report.num_matches, | ||
| ) | ||
|
|
||
|
|
||
| @dataclass | ||
| class RuleSetReport: | ||
| _decls: Declarations = field(repr=False) | ||
| changed: bool = False | ||
| rule_reports: dict[CommandDecl | str, list[RuleReport]] = field(default_factory=dict) | ||
| search_and_apply_time: timedelta = field(default_factory=timedelta) | ||
| merge_time: timedelta = field(default_factory=timedelta) | ||
|
|
||
| @classmethod | ||
| def _from_bindings( | ||
| cls, report: bindings.RuleSetReport, translate_key: Callable[[str], CommandDecl | str], decls: Declarations | ||
| ) -> RuleSetReport: | ||
| return cls( | ||
| _decls=decls, | ||
| changed=report.changed, | ||
| rule_reports={ | ||
| translate_key(k): [RuleReport._from_bindings(rr) for rr in v] for k, v in report.rule_reports.items() | ||
|
kaeun97 marked this conversation as resolved.
|
||
| }, | ||
| search_and_apply_time=report.search_and_apply_time, | ||
| merge_time=report.merge_time, | ||
| ) | ||
|
|
||
| def __repr__(self) -> str: | ||
| rule_reports_str = {_format_rule_key(self._decls, k): v for k, v in self.rule_reports.items()} | ||
| return ( | ||
| f"RuleSetReport(changed={self.changed}, " | ||
| f"rule_reports={rule_reports_str}, " | ||
| f"search_and_apply_time={self.search_and_apply_time}, " | ||
| f"merge_time={self.merge_time})" | ||
| ) | ||
|
|
||
|
|
||
| @dataclass | ||
| class IterationReport: | ||
| rule_set_report: RuleSetReport | ||
| rebuild_time: timedelta | ||
|
|
||
| @classmethod | ||
| def _from_bindings( | ||
| cls, report: bindings.IterationReport, translate_key: Callable[[str], CommandDecl | str], decls: Declarations | ||
| ) -> IterationReport: | ||
| return cls( | ||
| rule_set_report=RuleSetReport._from_bindings(report.rule_set_report, translate_key, decls), | ||
| rebuild_time=report.rebuild_time, | ||
| ) | ||
|
|
||
|
|
||
| @dataclass | ||
| class RunReport: | ||
| """Python-friendly wrapper around bindings.RunReport.""" | ||
|
|
||
| _decls: Declarations = field(repr=False) | ||
| iterations: list[IterationReport] = field(default_factory=list) | ||
| updated: bool = False | ||
| search_and_apply_time_per_rule: dict[CommandDecl | str, timedelta] = field(default_factory=dict) | ||
| num_matches_per_rule: dict[CommandDecl | str, int] = field(default_factory=dict) | ||
|
Comment on lines
+88
to
+89
Member
There was a problem hiding this comment. What if we just store CommandDecl's here regardless of if it has a name or not, then just change the repr/str to display it the name as a string if has one, otherwise pretty print the full command? |
||
| search_and_apply_time_per_ruleset: dict[str, timedelta] = field(default_factory=dict) | ||
| merge_time_per_ruleset: dict[str, timedelta] = field(default_factory=dict) | ||
| rebuild_time_per_ruleset: dict[str, timedelta] = field(default_factory=dict) | ||
|
|
||
| def __repr__(self) -> str: | ||
| time_per_rule = {_format_rule_key(self._decls, k): v for k, v in self.search_and_apply_time_per_rule.items()} | ||
| matches_per_rule = {_format_rule_key(self._decls, k): v for k, v in self.num_matches_per_rule.items()} | ||
| return ( | ||
| f"RunReport(iterations={self.iterations}, " | ||
| f"updated={self.updated}, " | ||
| f"search_and_apply_time_per_rule={time_per_rule}, " | ||
| f"num_matches_per_rule={matches_per_rule}, " | ||
| f"search_and_apply_time_per_ruleset={self.search_and_apply_time_per_ruleset}, " | ||
| f"merge_time_per_ruleset={self.merge_time_per_ruleset}, " | ||
| f"rebuild_time_per_ruleset={self.rebuild_time_per_ruleset})" | ||
| ) | ||
|
|
||
| @classmethod | ||
| def _from_bindings(cls, report: bindings.RunReport, state: EGraphState) -> RunReport: | ||
| return cls( | ||
| _decls=state.__egg_decls__, | ||
| iterations=[ | ||
| IterationReport._from_bindings(it, state.translate_rule_key, state.__egg_decls__) | ||
| for it in report.iterations | ||
| ], | ||
| updated=report.updated, | ||
| search_and_apply_time_per_rule={ | ||
| state.translate_rule_key(k): v for k, v in report.search_and_apply_time_per_rule.items() | ||
| }, | ||
| num_matches_per_rule={state.translate_rule_key(k): v for k, v in report.num_matches_per_rule.items()}, | ||
|
Member
There was a problem hiding this comment. When we build these dictionaries from the bindings, could we check for duplicate keys (either named or unnamed) and combine the values for them? So that for BiRewrite, we don't lose the first one? |
||
| search_and_apply_time_per_ruleset=report.search_and_apply_time_per_ruleset, | ||
| merge_time_per_ruleset=report.merge_time_per_ruleset, | ||
| rebuild_time_per_ruleset=report.rebuild_time_per_ruleset, | ||
| ) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add RunReport to
__all__