Modernize to C++17: replace deprecated aligned_storage, add nodiscard#170
Open
HFTrader wants to merge 1 commit intoefficient:masterfrom
Open
Modernize to C++17: replace deprecated aligned_storage, add nodiscard#170HFTrader wants to merge 1 commit intoefficient:masterfrom
HFTrader wants to merge 1 commit intoefficient:masterfrom
Conversation
Bump minimum standard from C++11 to C++17 and apply modernizations: - Replace deprecated std::aligned_storage (removed in C++26) with alignas + std::byte arrays in bucket_container. Use std::launder for pointer access to constructed objects, and a separate storage_ptr() for construct/destroy on uninitialized storage. - Add [[nodiscard]] to public query functions: hash_function(), key_eq(), get_allocator(), hashpower(), bucket_count(), empty(), size(), capacity(), load_factor(), contains(). - Mark primary constructor explicit to prevent implicit conversion from size_type. - Update CMake target_compile_features from cxx_constexpr to cxx_std_17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump minimum standard from C++11 to C++17 and apply modernizations:
std::aligned_storage(deprecated C++23, removed C++26) withalignas+std::bytearrays inbucket_container. Usestd::launderfor pointer access to constructed objects, and a separatestorage_ptr()for construct/destroy on uninitialized storage[[nodiscard]]to public query functions:hash_function(),key_eq(),get_allocator(),hashpower(),bucket_count(),empty(),size(),capacity(),load_factor(),contains()explicitto prevent implicit conversion fromsize_typetarget_compile_featuresfromcxx_constexprtocxx_std_17Test plan