Fix benchmark timing and minor warnings#168
Open
HFTrader wants to merge 1 commit intoefficient:masterfrom
Open
Fix benchmark timing and minor warnings#168HFTrader wants to merge 1 commit intoefficient:masterfrom
HFTrader wants to merge 1 commit intoefficient:masterfrom
Conversation
- Add thread barrier before starting the timer in universal_benchmark so that thread creation overhead is excluded from throughput measurement. Previously, start_time was captured before spawning threads, inflating measured wall time by 10-50us per thread. - Initialize res1/res2 in cuckoo_insert to silence -Wmaybe-uninitialized. Both are always set by try_find_insert_bucket() before use, but the compiler cannot prove this statically. - Fix unused parameter warning in upsert_fn lambda.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_timeinuniversal_benchmarkso that thread creation overhead is excluded from throughput measurement. Previously,start_timewas captured before spawning threads, inflating measured wall time by 10-50μs per thread.res1/res2incuckoo_insertto silence-Wmaybe-uninitialized. Both are always set bytry_find_insert_bucket()before use, but the compiler cannot prove this statically.upsert_fnlambda to silence-Wunused-parameter.Test plan