Fix member initialization order to match declaration order#167
Open
HFTrader wants to merge 1 commit intoefficient:masterfrom
Open
Fix member initialization order to match declaration order#167HFTrader wants to merge 1 commit intoefficient:masterfrom
HFTrader wants to merge 1 commit intoefficient:masterfrom
Conversation
Reorder the member initializer lists in all three non-default constructors to match the member declaration order. C++ initializes members in declaration order regardless of init-list order, so the previous ordering triggered -Wreorder warnings on every template instantiation (~90 warnings with -Wall). The actual initialization values are unchanged — this is purely a cosmetic fix to silence compiler diagnostics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Wreorderwarnings on every template instantiation (~90 warnings with-Wall)Test plan
-Wreorderwarnings with-Wall -Wextra -Wpedantic