Skip to content

Scope restored chat selections per chat#533

Merged
ericdallo merged 2 commits into
editor-code-assistant:masterfrom
rschmukler:rs/fix-variant-broadcast-on-chat-open
Jul 15, 2026
Merged

Scope restored chat selections per chat#533
ericdallo merged 2 commits into
editor-code-assistant:masterfrom
rschmukler:rs/fix-variant-broadcast-on-chat-open

Conversation

@rschmukler

Copy link
Copy Markdown
Contributor

Include chat-scoped model, variant, and trust updates during open, resume, and import, and return an atomic selection snapshot from chat/open.

Summary

  • Scope model, variant, and trust restoration from chat/open, /resume, and /import to the affected chat using chatId.
  • Return an atomic selection snapshot from chat/open containing the effective model, agent, variant, available variants, and trust state.
  • Keep scoped config/updated notifications for backward compatibility.
  • Correct the chat/open response field from found? to the documented found.
  • Add unit and end-to-end regression coverage for selection restoration.

Why

Previously, restoring chat A emitted session-wide config/updated notifications. Clients could therefore apply chat A’s model, variant, or trust state to chat B and to the defaults inherited by future chats.

Scoping these updates isolates each chat’s selection state. Including the complete selection in the chat/open response also lets clients hydrate a restored chat atomically rather than reconstructing its state from multiple independently ordered notifications.

  • I added a entry in changelog under unreleased section.
  • This is not an AI slop.

rschmukler and others added 2 commits July 15, 2026 12:41
Include chat-scoped model, variant, and trust updates during open, resume, and import, and return an atomic selection snapshot from chat/open.

@ericdallo ericdallo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server looks good, thanks!

@ericdallo ericdallo merged commit d3e901f into editor-code-assistant:master Jul 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants