Surface pending tool-calls to remote clients#476
Merged
ericdallo merged 1 commit intoMay 29, 2026
Merged
Conversation
The remote REST API only emitted toolCallRun via SSE, so a client connecting after a tool call entered :waiting-approval had no way to discover it — GET /api/v1/chats/:id omitted :tool-calls entirely and SSE never replays past events. The only recourse was to bounce back to the original editor to approve or reject. GET /api/v1/chats/:id now returns a pendingToolCalls array (empty when none) with id, name, server, origin, arguments, manualApproval, summary and details — matching the toolCallRun event shape so clients can render the approval card on first paint. Session and list-chats entries gain a pendingApprovalCount for inbox-style "attention needed" indicators without N round-trips. Tool-call summary/details/manual-approval are now persisted alongside :arguments at the :preparing -> :check-approval transition so the handler can return them without recomputation. Purely additive: no change to existing fields or SSE event semantics.
ericdallo
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remote REST API only emitted toolCallRun via SSE, so a client connecting after a tool call entered :waiting-approval had no way to discover it — GET /api/v1/chats/:id omitted :tool-calls entirely and SSE never replays past events. The only recourse was to bounce back to the original editor to approve or reject.
GET /api/v1/chats/:id now returns a pendingToolCalls array (empty when none) with id, name, server, origin, arguments, manualApproval, summary and details — matching the toolCallRun event shape so clients can render the approval card on first paint. Session and list-chats entries gain a pendingApprovalCount for inbox-style "attention needed" indicators without N round-trips. Tool-call summary/details/manual-approval are now persisted alongside :arguments at the :preparing -> :check-approval transition so the handler can return them without recomputation. Purely additive: no change to existing fields or SSE event semantics.