Skip to content

Add generic devices to WorkloadStatus #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clupuishere wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add generic devices to WorkloadStatus #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions protect/control/v1/common.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,7 @@ message WorkloadStatus {
WorkloadMountStatus mount_status = 5;
google.protobuf.Timestamp created_at = 6;
WorkloadPciDeviceStatus pci_device_status = 7;
WorkloadDeviceStatus device_status = 8;

@bleggett bleggett Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this conceptually differ from the existing

  • WorkloadBlockDeviceStatus
  • WorkloadPciDeviceStatus
  • WorkloadMountStatus

?

Do we need all three? If we do, why?

@clupuishere clupuishere Jun 11, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the long term, it should replace Workload{Block,Pci}DeviceStatus. Regarding WorkloadMountStatus that's a different (open) discussion given that it's related to filesystems and not to devices.

}

message WorkloadBlockDeviceInfo {
Expand All @@ -402,6 +403,10 @@ message WorkloadBlockDeviceInfo {
bool loop_dev = 5;
}

message WorkloadFsDeviceInfo {
uint64 device_id = 1;
}

message WorkloadPciDeviceInfo {
string location = 1;
}
Expand All @@ -414,6 +419,18 @@ message WorkloadPciDeviceStatus {
repeated WorkloadPciDeviceInfo devices = 1;
}

message WorkloadDeviceInfo {
oneof info {
WorkloadBlockDeviceInfo block = 1;
WorkloadFsDeviceInfo fs = 2;
WorkloadPciDeviceInfo pci = 3;
}
}

message WorkloadDeviceStatus {
repeated WorkloadDeviceInfo devices = 1;
}

message WorkloadMountInfo {
string tag = 2;
string host_path = 3;
Expand Down
Loading