Skip to content

Fix/cross year second pass#87

Open
theokaufman wants to merge 3 commits into
developmentfrom
fix/cross_year_second_pass
Open

Fix/cross year second pass#87
theokaufman wants to merge 3 commits into
developmentfrom
fix/cross_year_second_pass

Conversation

@theokaufman

Copy link
Copy Markdown

Fix for 475.

2 major changes:

  • in cross_year_pass: wrap the ID constraint logic in a conditional to ONLY constrain if we hit the match threshold in the first run. Otherwise, the second pass is run against the full list of possible ID columns
  • in orchestrate_earthmover: Make cross_year logic the default and fall back to enforce_match_threshold

@amazon-inspector-ohio

Copy link
Copy Markdown

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@theokaufman theokaufman requested a review from johncmerfeld June 29, 2026 13:00
@snyk-io-us

snyk-io-us Bot commented Jun 29, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@amazon-inspector-ohio

Copy link
Copy Markdown

✅ I finished the code review, and didn't find any security or code quality issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant