Skip to content

ECC-2280: Don't link libaec when ENABLE_AEC=OFF#488

Open
tomas-kral wants to merge 1 commit into
ecmwf:developfrom
tomas-kral:bugfix/ECC-2280-enable-aec-off
Open

ECC-2280: Don't link libaec when ENABLE_AEC=OFF#488
tomas-kral wants to merge 1 commit into
ecmwf:developfrom
tomas-kral:bugfix/ECC-2280-enable-aec-off

Conversation

@tomas-kral

Copy link
Copy Markdown
Collaborator

Description

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@joobog joobog added the approved-for-ci Approved to run CI on ECMWF machines label Jun 3, 2026
@joobog

joobog commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

I think it makes sense to modernise this part a bit more. It was developed when libaec did not yet support CMake. If the solution in this branch works for you, I would prefer to use it:

https://github.com/ecmwf/eccodes/tree/bugfix/ecc-2280_libaec_linking

@tomas-kral

Copy link
Copy Markdown
Collaborator Author

Hi @joobog, thanks for looking at this! I'm happy whith whichever solution as long as it works as intended. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-for-ci Approved to run CI on ECMWF machines contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants