Expose key material of EC JWKs again - #763
Open
jnbdz wants to merge 1 commit into
Open
Conversation
Since a9d1ad4 JWK.publicKey()/privateKey() resolve the key through signingAlgorithm.unwrap(). EC keys are wrapped by wrapECAlgo to convert between JWS and ASN.1 signatures, and that wrapper did not override unwrap(), so the chain stopped at the wrapper and both accessors returned null for ES256/ES384/ES512/ES256K keys (JSON JWK, PEM and keystore alike). The wrapper now delegates unwrap() to the wrapped algorithm. JWKTest gains EC public/private (JSON and PEM) assertions with RSA as control. Fixes eclipse-vertx#762
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #762
Regression from a9d1ad4:
JWK.publicKey()/privateKey()now go throughsigningAlgorithm.unwrap(), but the anonymous EC wrapper created byJWK.wrapECAlgo(...)did not overrideunwrap(), so for every EC key (ES256/ES384/ES512/ES256K, from JSON JWK, PEM or keystore) the chain stopped at the wrapper and both accessors returnednull. RSA/PS/EdDSA keys were unaffected because they are not wrapped.Fix: the wrapper delegates
unwrap()to the wrappedDigitalSigningAlgorithm(one method). Nothing else about the wrapper changes — signing/verification still convert between JWS R+S and ASN.1 as before.Tests:
JWKTestgainspublicECExposesPublicKey,privateECExposesKeyPair,pemECExposesKeys(all failed before the fix) andpemRSAExposesPublicKeyas a control. vertx-auth-common, vertx-auth-jwt and vertx-auth-oauth2 suites are green locally.