Allow mapping authentication query columns to user attributes - #756
Open
jnbdz wants to merge 1 commit into
Open
Conversation
The SQL authentication provider discards every column of the authentication query except the password, forcing a second query to load user data such as its id right after authentication. Add a SqlAuthentication.create overload taking a mapping function that receives the authenticated row and returns a JSON object to merge into the user attributes. The password remains expected in the first column and options stay data only, following the guidance in the issue. Fixes eclipse-vertx#694
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SQL authentication provider discards every column of the authentication query except the password (
row.getString(0)), so callers that need more user data right after login — typically the user id for a session or token — have to run a second query for the row they just fetched.Following the guidance in #694, this adds a
SqlAuthentication.create(client, options, attributeMapper)overload where the mapper is aFunction<Row, JsonObject>living on the auth type (options stay data-only). The mapper receives the authenticated row and the returned JSON object is merged into the authenticatedUserattributes:Behavior notes:
createoverloads are unchangednullmapper result is ignoredIncludes a test in
MySQLTest(the DDL gains a nullableemailcolumn), an example and documentation.Fixes #694