282 binaryreferencetraverser bounds check for variable length members

[hg-ms]

fixes #282

Serializer + Store required

[Copilot]

Pull request overview

This PR addresses issue #282 by adding bounds-checked traversal paths to prevent variable-length member corruption from driving out-of-bounds memory reads during reference iteration, converting potential hard JVM crashes into BinaryPersistenceExceptions.

Changes:

• Added a bounds-aware apply(address, bound, acceptor) default method to BinaryReferenceTraverser and a bounds-checked iterateReferences(address, bound, traversers, acceptor) overload.
• Introduced validateVariableLengthBound(...) and updated variable-length traversers to validate list byte lengths against a provided bound.
• Updated complex variable-length traversal to validate list byte length before iterating elements, and fixed a spelling typo (“truely” → “truly”).

Comments suppressed due to low confidence (1)

persistence/binary/src/main/java/org/eclipse/serializer/persistence/binary/types/BinaryReferenceTraverser.java:1379

• In InlinedComplexType, listBound is computed from the validated list byte length, but the method returns a (end of iterated elements). If elementCount is corrupted too small, this returns a cursor inside the list, causing subsequent member traversers to interpret remaining element bytes as following fields. Returning the validated listBound keeps the cursor aligned with the list’s declared length.

			// return resulting address for recursive continued use
			return a;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.