Improve UX for file selection in the Common tab#2817
Conversation
SougandhS
changed the title
|
I don't think this can be quite right. The enable argument might be false and still you would call set focus. I also wonder how this makes sense when the common tab is not visible (is not the active tab) or what the impact of this is while using keyboard navigation to navigate all the launch configurations... |
weird, I remember I added enabled condition and pushed that change.. let me push that again. |
I'll check this |
Handled this to activate only during selections.. 👍 |
Automatically focus the associated file path text field when the Shared file, Input File, or Output File option is selected in the Common tab, allowing users to immediately enter or browse for the corresponding file location without an additional click.
|
That seems more sensible. I wonder though, how does this affect keyboard users? Maybe in a good way? 😀 |
On mac I see no benefits with keyboards, using |
|
On Windows the up and down arrow keys change the radio button selection and also cycle to the browse button. With this change, the focus moves to the entry field as soon as you navigate to the second radio button via down arrow whereas previous one could navigate to the browse button which is probably the more likely next thing you want to do... Is there anyone on your team who can test the behavior on Windows? I'm really not 100% sure this is an improvement. Maybe @iloveeclipse or @HeikoKlare have an opinion? |
|
I've tested on Linux and it looks OK. So LGTM from my side. |
In my opinion, this introduces a new UX concept at a single place only. There are other places with the same pattern (selecting a radio option enables a text field in which you can define a location), e.g.: In my opinion, establishing this concpet at a single place will lead to more confusion than improvement. The average user who does not heavily use this input field will not know and value that at this specific field the user interaction behaves different than anywhere else. They may rather be confused why the interaction is inconsistent to everywhere else. So I would generally vote against this kind of behavior changes without a holistic (and consistently applied) UX concept for such a change. Though I think this specific place will not be that problematic due to being rarely used (which I why I would not block this kind of change), still making Eclipse UX more inconsistent. @BeckerWdf wdyt? |
|
I agree with Heiko. Consistency is the prio 1 topic in UX. Changing interaction patterns only in single places (and not in a holistic way) does worsen the UX of the overall product. |
5 participants
Set focus to the shared location text field when the "Shared file" option is selected in the launch configuration dialog. This allows users to immediately enter or browse for the shared configuration location without requiring an additional click.