Allow reordering terminal tabs via drag and drop#2681
Conversation
Test Results 54 files ± 0 54 suites ±0 36m 47s ⏱️ + 1m 10s For more details on these errors, see this check. Results for commit 75a1ea4. ± Comparison against base commit 859044c. ♻️ This comment has been updated with latest results. |
|
Needs the change in SWT, which should be available tomorrow, after that this can be tested. |
Dragging a terminal tab within the same Terminals view now reorders it to the drop position, matching the drag-to-reorder behavior of editor and view tabs. The drop within the same view was previously rejected. The reorder uses the new CTabFolder.moveItem(int, int) API, so the live terminal control stays attached and no longer has to be recreated. The existing cross-view move (which transfers a terminal to a different Terminals view) is unchanged, as it still requires re-parenting. Requires SWT 3.135. Fixes eclipse-platform#2679
e6aed94 to
9d4e6d6
Compare
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Dragging a terminal tab within the same Terminals view now reorders it to the drop position, the same way editor and view tabs can be rearranged.
Previously a drop inside the originating view was rejected, so tabs could only be moved to a different Terminals view.
The reorder relies on the new
CTabFolder.moveItem(int, int)API (SWT 3.135, eclipse-platform/eclipse.platform.swt#3350), which keeps the live terminal control attached instead of recreating it.The existing cross-view move is left untouched because transferring a terminal to a different view still requires re-parenting.
Draft because it depends on SWT 3.135, which is not yet in the platform target platform, so CI cannot build it until that lands.
Fixes #2679