Skip to content

Simplify SymLink creation in eclipse.core.tests#1486

Open
HannesWell wants to merge 2 commits into
eclipse-platform:masterfrom
HannesWell:simplify-symlink-creation
Open

Simplify SymLink creation in eclipse.core.tests#1486
HannesWell wants to merge 2 commits into
eclipse-platform:masterfrom
HannesWell:simplify-symlink-creation

Conversation

@HannesWell
Copy link
Copy Markdown
Member

As discussed in #755 (comment).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 30, 2024

Test Results

    45 files   -   9      45 suites   - 9   34m 40s ⏱️ -7s
 4 513 tests  - 154   4 484 ✅  - 161   22 💤 ±0   7 ❌ + 7 
11 433 runs   - 462  11 263 ✅  - 479  153 💤 ±0  17 ❌ +17 

For more details on these failures, see this check.

Results for commit 85a1244. ± Comparison against base commit 7f435dc.

This pull request removes 154 tests.
org.eclipse.compare.tests.AsyncExecTests ‑ testCancelOnRequeue
org.eclipse.compare.tests.AsyncExecTests ‑ testQueueAdd
org.eclipse.compare.tests.AsyncExecTests ‑ testWorker
org.eclipse.compare.tests.CompareFileRevisionEditorInputTest ‑ testPrepareCompareInputWithNonLocalResourceTypedElements
org.eclipse.compare.tests.CompareUIPluginTest ‑ testFindContentViewerDescriptorForTextType_StreamAccessor
org.eclipse.compare.tests.CompareUIPluginTest ‑ testFindContentViewerDescriptor_TextType_NotStreamAccessor
org.eclipse.compare.tests.CompareUIPluginTest ‑ testFindContentViewerDescriptor_UnknownType
org.eclipse.compare.tests.ContentMergeViewerTest ‑ testFFFX
org.eclipse.compare.tests.ContentMergeViewerTest ‑ testFFTX
org.eclipse.compare.tests.ContentMergeViewerTest ‑ testFFXF
…

♻️ This comment has been updated with latest results.

@akurtakov akurtakov force-pushed the simplify-symlink-creation branch from 20654f8 to 1439588 Compare August 9, 2024 18:31
@akurtakov akurtakov force-pushed the simplify-symlink-creation branch from 1439588 to cd77681 Compare November 26, 2024 20:22
@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

eclipse-platform-bot commented Nov 26, 2024

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

runtime/tests/org.eclipse.core.tests.harness/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 6f0780a1a73d48476dfb80fd369454a4c4bc1203 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Sat, 30 May 2026 04:27:31 +0000
Subject: [PATCH] Version bump(s) for 4.41 stream


diff --git a/runtime/tests/org.eclipse.core.tests.harness/META-INF/MANIFEST.MF b/runtime/tests/org.eclipse.core.tests.harness/META-INF/MANIFEST.MF
index 63dba3b3e1..624a2e0eb5 100644
--- a/runtime/tests/org.eclipse.core.tests.harness/META-INF/MANIFEST.MF
+++ b/runtime/tests/org.eclipse.core.tests.harness/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: Eclipse Core Tests Harness
 Bundle-SymbolicName: org.eclipse.core.tests.harness;singleton:=true
-Bundle-Version: 3.17.500.qualifier
+Bundle-Version: 3.17.600.qualifier
 Bundle-Vendor: Eclipse.org
 Export-Package: org.eclipse.core.tests.harness;version="2.0",
  org.eclipse.core.tests.harness.session
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

@akurtakov akurtakov force-pushed the simplify-symlink-creation branch from 18f2896 to ea84d8f Compare June 6, 2025 08:55
@vogella vogella force-pushed the simplify-symlink-creation branch 3 times, most recently from 7defb9c to 4e8edfa Compare January 12, 2026 14:38
@vogella
Copy link
Copy Markdown
Contributor

vogella commented Jan 12, 2026

@HannesWell I did the update of your PR, I hope that is ok. Your change looked just to good to be lost.

@HannesWell HannesWell force-pushed the simplify-symlink-creation branch from 4e8edfa to 465b3d5 Compare January 13, 2026 00:02
@HannesWell
Copy link
Copy Markdown
Member Author

I did the update of your PR, I hope that is ok. Your change looked just to good to be lost.

Yes, of course. Thank you for updating it.

Unfortunately there are (still) failing tests with this and I didn't had the time to investigate the reasons (which is why this staled).
If you can have a look, any help is appreciated.

@HannesWell HannesWell force-pushed the simplify-symlink-creation branch from 465b3d5 to 6fbe9c4 Compare May 30, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants