Suppress duplicated key event handling in Linux/GTK3 #4199#4200
Open
fedejeanne wants to merge 1 commit into
Open
Suppress duplicated key event handling in Linux/GTK3 #4199#4200fedejeanne wants to merge 1 commit into
fedejeanne wants to merge 1 commit into
Conversation
Contributor
Test Results 855 files ±0 855 suites ±0 59m 26s ⏱️ + 8m 48s For more details on these failures, see this check. Results for commit 319c5cd. ± Comparison against base commit 5fe0fc9. ♻️ This comment has been updated with latest results. |
iloveeclipse
left a comment
iloveeclipse
left a comment
Member
There was a problem hiding this comment.
There are some test fails btw...
Member
|
Beside test failure, the patch seem to work. Tried on RHEL 9.6 / X11 |
native key event (Linux/GTK) On GTK (Linux), a single physical key press can, in some situations, be delivered to KeyBindingDispatcher twice for the very same native event: once synchronously via an SWT.Traverse event dispatched from within the native gtk3_key_press_event handling, and once more later via the async message queue. Both deliveries resolve to and execute the exact same bound command, which for page-traversal shortcuts like Ctrl+PageUp / Ctrl+PageDown (Next/Previous Editor) causes an extra tab to be skipped, since the CTabFolder selection is advanced twice per key press. This does not reproduce on Windows or macOS, only on GTK. Fix: track the last executed command together with the native timestamp (Event#time) of its triggering event in executeCommand(...), and skip (without re-executing the handler) a call that matches both the same command and the same event timestamp, since that combination can only happen when the very same native key event is redelivered. Genuinely distinct key presses - including fast auto-repeat - always carry different timestamps, so normal navigation and repeated shortcuts are unaffected. This is reported as the 'bonus' issue in eclipse-platform#4135 (Javadoc View tab cycling two tabs per Ctrl+PageUp/PageDown on Linux). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fedejeanne
force-pushed
the
fix-linux-gtk-double-traversal
branch
from
July 23, 2026 08:02
e66fdd7 to
319c5cd
Compare
Member
Reproducible locally, the test was added via 172b704 for https://bugs.eclipse.org/bugs/show_bug.cgi?id=294509, unfortunately bugzilla is down ATM. |
Member
|
OK, the test is supposed to test this:
|
Member
Author
|
I am looking into it. I suspect something is wrong with the tests because even though they only fail when applying this PR, I also noticed that:
This smells like a bad state after a test ran. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4199
How to test
Navigate the views with
Ctrl + PgUp/Ctrl + PgDnlike I did in the video in #4199, no view should be skipped.