Find/replace tests: assert proper selection of options#4198
Merged
HeikoKlare merged 1 commit intoJul 21, 2026
Merged
Conversation
In case search options are not properly selected/unselected in tests, test may be effectively executed with different search options than expected and succeed without identifying issues when having the options properly selected/unselected. This adds according assertions to make sure that selection changes succeed. This also enhances the order of test execution in the texteditor test suite.
HeikoKlare
force-pushed
the
findreplace-tests-selection-assertions
branch
from
July 21, 2026 11:15
a7fad79 to
ac65457
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case search options are not properly selected/unselected in tests, test may be effectively executed with different search options than expected and succeed without identifying issues when having the options properly selected/unselected. This adds according assertions to make sure that selection changes succeed.
This also enhances the order of test execution in the texteditor test suite.
This is an extract of / preparation for: