Find/Replace overlay: use handler enablement for button enabled state#4195
Open
HeikoKlare wants to merge 1 commit into
Open
Find/Replace overlay: use handler enablement for button enabled state#4195HeikoKlare wants to merge 1 commit into
HeikoKlare wants to merge 1 commit into
Conversation
Contributor
HeikoKlare
force-pushed
the
findreplace-overlay-handler-enablement
branch
from
July 19, 2026 08:59
8d4a5a8 to
dec90cd
Compare
The enablement of the buttons for search options of the find/replace overlay are currently derived from the availability of the underlying search option. However, there are actions attached to the buttons (changing activation of the search option) and the button enablement should actually reflect if that action is available or not. Though these are effectively equal, mapping the button enablement to the action availability is the conceptually more correct representation. With this change, FindReplaceOverlayAction extends AbstractHandler, making the action itself a handler and providing and enablement state. Enablement of the buttons for the search options is not kept in sync with enablement of the action/handler via an according handler listener. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
HeikoKlare
force-pushed
the
findreplace-overlay-handler-enablement
branch
from
July 19, 2026 17:38
dec90cd to
af60bf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The enablement of the buttons for search options of the find/replace overlay are currently derived from the availability of the underlying search option. However, there are actions attached to the buttons (changing activation of the search option) and the button enablement should actually reflect if that action is available or not. Though these are effectively equal, mapping the button enablement to the action availability is the conceptually more correct representation.
With this change, FindReplaceOverlayAction extends AbstractHandler, making the action itself a handler and providing and enablement state. Enablement of the buttons for the search options is not kept in sync with enablement of the action/handler via an according handler listener.
This is a standalone-reasonable change extracted from: